sshdriver: log verbose scp output #1285
Conversation
Adds the `-v` option to all scp calls and saves the output to the logger. The additional output can help debug scp failures. Signed-off-by: Nick Potenski <[email protected]>
nick-potenski
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
========================================
- Coverage 63.0% 62.9% -0.1%
========================================
Files 160 160
Lines 11902 11907 +5
========================================
- Hits 7500 7499 -1
- Misses 4402 4408 +6
☔ View full report in Codecov by Sentry. |
|
Thanks for thinking about contributing. I can't really see how this "debugging improvement" benefits labgrid. Even without this change, critical output of scp should still be visible on stdout, right? What kind of errors are you debugging? |
|
In this case, a call to |
|
Hm, I see why you've added that for your debugging session, but I don't think that adding |
|
As explained earlier, I'll close this. |
Description
Adds the
-voption to all scp calls and saves the output to the logger. The get and put methods log at warning level on failure and the scp method logs at info level always. The additional output can help debug scp failures. Tested by trying to transfer non-existent files in both directions inside a test and verifying that the pytest logs included similar output to raw calls to scp.Checklist